Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Turbopack] fix root and project path usages in a monorepo #73552

Merged
merged 12 commits into from
Dec 19, 2024
Merged

[Turbopack] fix root and project path usages in a monorepo #73552

merged 12 commits into from
Dec 19, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Dec 5, 2024 •
edited by padmaia
Loading

What?

Improved trace source maps to return relative paths and always relative to process.cwd.

turbopack:// urls in SourceMaps are always relative to the project root.

file:// urls do no longer contain duplicate path segments.

Add a test case

Also:

  • improve error when sourcemap lookup throws

Closes PACK-3671

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. tests Turbopack Related to Turbopack with Next.js. type: next labels Dec 5, 2024
@sokra Graphite App
Copy link
Member Author

sokra commented Dec 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 5, 2024
Merged
Draft
@sokra sokra force-pushed the sokra/fix-monorepo-paths branch from 9d3367a to f70e8a5 Compare December 5, 2024 15:45
@sokra sokra changed the title remove the next.js tarballs after the test has finished [Turbopack] fix root and project path usages in a monorepo Dec 5, 2024
@ijjk
Copy link
Member

ijjk commented Dec 5, 2024 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 5, 2024 •
edited
Loading

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/fix-monorepo-paths Change
buildDuration 17.6s 15.7s N/A
buildDurationCached 14.9s 12.6s N/A
nodeModulesSize 416 MB 416 MB ⚠️ +4.58 kB
nextStartRea..uration (ms) 473ms 453ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/fix-monorepo-paths Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/fix-monorepo-paths Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sokra/fix-monorepo-paths Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/fix-monorepo-paths Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/fix-monorepo-paths Change
index.html gzip 524 B 524 B ✓
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 521 B N/A
Overall change 524 B 524 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/fix-monorepo-paths Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 205 kB 205 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sokra/fix-monorepo-paths Change
middleware-b..fest.js gzip 669 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js sokra/fix-monorepo-paths Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 356 kB 356 kB ✓
app-page-exp..prod.js gzip 129 kB 129 kB ✓
app-page-tur..prod.js gzip 142 kB 142 kB ✓
app-page-tur..prod.js gzip 137 kB 137 kB ✓
app-page.run...dev.js gzip 347 kB 347 kB ✓
app-page.run..prod.js gzip 125 kB 125 kB ✓
app-route-ex...dev.js gzip 37.5 kB 37.5 kB ✓
app-route-ex..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.3 kB 25.3 kB ✓
app-route.ru...dev.js gzip 39.1 kB 39.1 kB ✓
app-route.ru..prod.js gzip 25.3 kB 25.3 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.43 MB 2.43 MB ✓
build cache
vercel/next.js canary vercel/next.js sokra/fix-monorepo-paths Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 74.8 kB 74.8 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 8e343d7

@sokra sokra requested a review from eps1lon December 5, 2024 16:10
sokra
sokra commented Dec 5, 2024
View reviewed changes
test/integration/server-side-dev-errors/test/index.test.js
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eps1lon see here

@sokra sokra force-pushed the sokra/fix-monorepo-paths branch from d1bfcc3 to 8074d4c Compare December 6, 2024 07:53
This was referenced Dec 6, 2024
Draft
Draft
Draft
@sokra sokra force-pushed the sokra/fix-monorepo-paths branch from d0f6b28 to 466d6b8 Compare December 9, 2024 07:34
@sokra sokra force-pushed the sokra/fix-monorepo-paths branch from 466d6b8 to 2b7ca40 Compare December 19, 2024 08:27
@sokra sokra marked this pull request as ready for review December 19, 2024 10:34
eps1lon
eps1lon approved these changes Dec 19, 2024
View reviewed changes
test/e2e/app-dir/non-root-project-monorepo/non-root-project-monorepo.test.ts
await assertHasRedbox(browser)

if (isTurbopack) {
// TODO the function name should be hidden
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@sokra sokra merged commit 53bb90c into canary Dec 19, 2024
129 of 134 checks passed
@sokra Graphite App
Copy link
Member Author

sokra commented Dec 19, 2024

Merge activity

  • Dec 19, 6:56 AM EST: A user merged this pull request with Graphite.

@sokra sokra deleted the sokra/fix-monorepo-paths branch December 19, 2024 11:56
@eps1lon eps1lon mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. tests Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @ijjk @eps1lon